Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add keyExists to stdJson and stdToml #605

Merged
merged 2 commits into from
Sep 19, 2024
Merged

feat: add keyExists to stdJson and stdToml #605

merged 2 commits into from
Sep 19, 2024

Conversation

mds1
Copy link
Collaborator

@mds1 mds1 commented Sep 18, 2024

Hey @zerosnacks @klkvr can I get a quick review here?

One thing I'm wondering: why are the keyExists cheats view but the other JSON/TOML parsing cheats are pure?

@mds1 mds1 mentioned this pull request Sep 18, 2024
Open
mattsse
mattsse approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are fine, right @klkvr ?

zerosnacks
zerosnacks approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed API LGTM

I don't think there is a clear reason for marking these as view

klkvr
klkvr approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

yeah, we can probably make it pure

@mds1 mds1 merged commit 5a802d7 into master Sep 19, 2024
3 checks passed
@mds1 mds1 mentioned this pull request Oct 1, 2024
Closed
@DaniPopes DaniPopes deleted the key-exists branch October 24, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@klkvr klkvr klkvr approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mds1 @mattsse @klkvr @zerosnacks